The basics

• I branched from develop
• My pull request is against develop
• My code follows the style guide
• I ran npm run format and npm run lint

The details

Resolves

Fixes inconsistency in our API. The init method on a field is @sealed and @internal. The documentation says to override initView and initModel instead. However, those methods were also marked @internal meaning they couldn't actually be overridden.

Proposed Changes

• Make initView protected because it's only used inside subclasses of fields
• Make initModel public because it's also used from within block serialization code
• Refactor usage of initModel in block serialization code because the old style of for loop was causing the field to be typed as any which breaks reference searching. Now, "find all references" will actually find them all.
• Makes imageElement and imageHeight protected in field_image. Having the image element be @internal makes the image field almost impossible to subclass. If you want to use dynamic image fields that can change images, you have to subclass the image field.

Behavior Before Change

• Unable to subclass certain fields effectively

Behavior After Change

• Able to subclass fields and change their dom structure

Reason for Changes

• Improving documentation and making our API more consistent
• Code.org needs to be able to subclass image field for dynamic images

Test Coverage

All tests pass and manually tested serialization in playground.

Documentation

These methods will be included in the next documentation update through api-documenter

Additional Information